[virt-tools-list] [PATCH] virt-manager: Don't print traceback if hal is missing.

Marc Deslauriers marc.deslauriers at canonical.com
Sun Feb 27 19:25:58 UTC 2011


Hello,

Since HAL is deprecated and most distros don't install it by default
anymore, this patch removes the traceback from being printed by
virt-manager at each startup as the error message is enough. Also gets
rid of useless %s.

Thanks,

Marc.

# HG changeset patch
# User Marc Deslauriers <marc.deslauriers at ubuntu.com>
# Date 1298834453 18000
# Node ID b91f34bf37f20ed403d0e78e9d366fccad2080e4
# Parent  134adf33f6f4d3d600568b175fb8d37a0762285f
Don't print traceback if hal is missing.

diff -r 134adf33f6f4 -r b91f34bf37f2 src/virtManager/halhelper.py
--- a/src/virtManager/halhelper.py	Thu Feb 24 11:38:40 2011 -0500
+++ b/src/virtManager/halhelper.py	Sun Feb 27 14:20:53 2011 -0500
@@ -83,9 +83,8 @@
         except Exception, e:
             (_type, value, stacktrace) = sys.exc_info()
             logging.error("Unable to connect to HAL to list network "
-                          "devices: '%s'" +
-                          str(_type) + " " + str(value) + "\n" +
-                          traceback.format_exc(stacktrace))
+                          "devices: " +
+                          str(_type) + " " + str(value))
             self.startup_error = str(e)
 
     def connect(self, name, callback, *args):





More information about the virt-tools-list mailing list