[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [python-virtinst 1/2] virt-install: Use same name for disks as libosinfo



On 07/01/2011 04:32 PM, Zeeshan Ali (Khattak) wrote:
> From: "Zeeshan Ali (Khattak)" <zeeshanak gnome org>
> 
> ---
>  virtinst/VirtualDevice.py |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/virtinst/VirtualDevice.py b/virtinst/VirtualDevice.py
> index 87af418..5a6f347 100644
> --- a/virtinst/VirtualDevice.py
> +++ b/virtinst/VirtualDevice.py
> @@ -27,7 +27,7 @@ class VirtualDevice(XMLBuilderDomain):
>      Base class for all domain xml device objects.
>      """
>  
> -    VIRTUAL_DEV_DISK            = "disk"
> +    VIRTUAL_DEV_DISK            = "block"
>      VIRTUAL_DEV_NET             = "interface"
>      VIRTUAL_DEV_INPUT           = "input"
>      VIRTUAL_DEV_GRAPHICS        = "graphics"

Please read the HACKING file in the top level of the git checkout: This
breaks the unit tests (python setup.py test). Also these values
correspond to the device XML name in the libvirt XML schema so should
not be changed.

Thanks,
Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]