[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH virt-manager v4] Add inspection to virt-manager



On Tue, Jul 19, 2011 at 08:49:33AM +0100, Richard W.M. Jones wrote:
> On Mon, Jul 18, 2011 at 05:41:00PM -0400, Cole Robinson wrote:
> crobinso> rjones: I'm thinking of adding a disk path access check in
>                   the inspection thread, to avoid flooding the logs
>                   with errors if we can't even read the disk
>                   image. that should be safe to do?
>
> AFAICT if there's no access to the disks, then the call to either
> g.add_drive_opts or g.launch will throw an exception.

I wanted to add: adding a test in virt-manager is going to be tricky.

Because qemu is an external program, SELinux can cause things to fail
even if the file is apparently readable by the main program.  So I
think we need to let libguestfs run qemu, and instead concentrate on
catching/quieting the exception (if that's necessary).

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
New in Fedora 11: Fedora Windows cross-compiler. Compile Windows
programs, test, and build Windows installers. Over 70 libraries supprt'd
http://fedoraproject.org/wiki/MinGW http://www.annexia.org/fedora_mingw


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]