[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH virt-manager v4] Add inspection to virt-manager



On Tue, Jul 19, 2011 at 10:43:42AM -0400, Cole Robinson wrote:
> On 07/19/2011 03:51 AM, Richard W.M. Jones wrote:
> > On Tue, Jul 19, 2011 at 08:49:33AM +0100, Richard W.M. Jones wrote:
> >> On Mon, Jul 18, 2011 at 05:41:00PM -0400, Cole Robinson wrote:
> >> crobinso> rjones: I'm thinking of adding a disk path access check in
> >>                   the inspection thread, to avoid flooding the logs
> >>                   with errors if we can't even read the disk
> >>                   image. that should be safe to do?
> >>
> >> AFAICT if there's no access to the disks, then the call to either
> >> g.add_drive_opts or g.launch will throw an exception.
> > 
> > I wanted to add: adding a test in virt-manager is going to be tricky.
> > 
> 
> A test wouldn't be perfect, but it's pretty easy to do
> 
> if not (os.path.exists(path) and os.access(path, os.R_OK)):
>     # skip disk

We can't just add some disks and not others from a guest.  We have to
skip the whole guest if any disk is inaccessible.  I'll put together a
patch.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]