[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH 02/10] Modified libvirtwork to use vmmNetwork objects.



On Tue, May 31, 2011 at 12:55:18PM -0400, Cole Robinson wrote:
> > -        result = self.__conn.networkLookupByName(name)
> > -        if result is None: raise Exception("No such network exists: %s" % name)
> > +        result = self.__vmmconn.get_net(uuid)
> > +        if result is None: raise Exception("No such network exists: uuid=%s" % uuid)
> >  
> 
> get_net won't ever return None, it will throw it's own exception. That
> can be a follow up though.
> 
> ACK to the series, I've pushed it now.

KK - I'll make a note to go back and re-address that case. Thanks for
the push. :)

-- 
Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc.
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/

Attachment: pgpqABVOVH3bX.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]