[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [libosinfo 4/4] API to indicate media is live and/or installer



On Thu, Nov 24, 2011 at 4:16 PM, Christophe Fergeau <cfergeau redhat com> wrote:
> On Thu, Nov 24, 2011 at 04:04:26PM +0200, Zeeshan Ali (Khattak) wrote:
>>   You do realize that vala is expecting it like this cause its the
>> most usual convention in gobject world? Check similar functions in
>> gtk+ for example: gtk_widget_get_child_visible().
>
> gdk_keyval_is_lower? Ok it's the only one in gtk proper, but there are
> other libraries out there using "is"

  Thats irrelevant since gdk_keyval_is_lower() is *not* a getter for a
gobject prop.

>> I wouldn't want to
>> do that extra work just to make the names of getters sound *slightly*
>> better.
>
> Yep, better to put some extra mental work on people reading code using
> these getters. It's generally an accumulation of small nice details or
> small irritations that makes people think of a library as nice to use or
> not.

  True but I don't think thats the case here since I'm sticking to the
usual conventions.

-- 
Regards,

Zeeshan Ali (Khattak)
FSF member#5124


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]