[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [libosinfo PATCH] Fix libxml error reporting



On Fri, Nov 25, 2011 at 10:32:41AM +0100, Christophe Fergeau wrote:
> On Fri, Nov 25, 2011 at 09:30:27AM +0100, Guido Günther wrote:
> > On Fri, Nov 18, 2011 at 11:03:41PM +0100, Guido Günther wrote:
> > > The error code might be set in catchXMLError so make sure we don't miss
> > > it. Otherwise this results in errors like:
> > > 
> > > /usr/lib/python2.7/dist-packages/gi/types.py:43: Warning: GError set over the top of a previous GError or uninitialized memory.
> > > This indicates a bug in someone's code. You must ensure an error is NULL before it's set.
> > > The overwriting error message was: Incorrect root element
> > 
> > Can this be appplied?
> 
> ACK, do you have commit access or should I push it. Fwiw, the test should
> be if (!xml || (err && *err)) to handle err being NULL when the caller is
> not interested in the error, but none of the code in osinfo_loader does
> this, so better to fix all of these in one go.
No, I don't have commit access.
 -- Guido


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]