[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [libosinfo 1/2] Add utility app that detects OS given a media



On Tue, Aug 30, 2011 at 09:30:15PM +0300, Zeeshan Ali (Khattak) wrote:
> From: "Zeeshan Ali (Khattak)" <zeeshanak gnome org>
> 
> Given a path to a ISO9660 image/device, detects if media is bootable and
> the relavent OS if media is an installer for it.
> ---
>  Makefile.am           |    2 +-
>  configure.ac          |    1 +
>  tools/Makefile.am     |   15 +++++
>  tools/osinfo-detect.c |  157 +++++++++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 174 insertions(+), 1 deletions(-)
>  create mode 100644 tools/Makefile.am
>  create mode 100644 tools/osinfo-detect.c
> 
> diff --git a/Makefile.am b/Makefile.am
> index 92220ea..8ee8bb0 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -1,5 +1,5 @@
>  
> -SUBDIRS = osinfo test data docs examples scripts
> +SUBDIRS = osinfo test data tools docs examples scripts
>  
>  EXTRA_DIST = \
>    COPYING.LIB \
> diff --git a/configure.ac b/configure.ac
> index bf5681b..324c0a1 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -118,6 +118,7 @@ AC_CONFIG_FILES([
>  	data/devices/Makefile
>  	data/hypervisors/Makefile
>  	data/oses/Makefile
> +	tools/Makefile
>  	scripts/Makefile
>  	test/Makefile
>  	docs/Makefile
> diff --git a/tools/Makefile.am b/tools/Makefile.am
> new file mode 100644
> index 0000000..4de1e8f
> --- /dev/null
> +++ b/tools/Makefile.am
> @@ -0,0 +1,15 @@
> +AM_CFLAGS = $(GOBJECT_CFLAGS) \
> +	    $(GIO_CFLAGS)     \
> +	    $(LIBXML_CFLAGS)  \
> +	    -I$(top_srcdir)
> +
> +bin_PROGRAMS = osinfo-detect
> +
> +osinfo_detect_SOURCES = osinfo-detect.c
> +
> +osinfo_detect_LDADD = $(GOBJECT_LIBS) 	     \
> +		      $(GIO_LIBS)     	     \
> +		      $(LIBXML_LIBS)  	     \
> +		      -L$(top_srcdir)/osinfo \
> +		      -losinfo-1.0

I'm not entirely sure if it has any functional difference, but
I think it is slightly better to remove the -L and -l lines
and instead reference the .la file directly

    ../osinfo/libosinfo-1.0.la


ACK, with that change made before pushing

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]