[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [libosinfo 1/2] Add utility app that detects OS given a media



On Thu, Sep 1, 2011 at 1:37 PM, Daniel P. Berrange <berrange redhat com> wrote:
> On Tue, Aug 30, 2011 at 09:30:15PM +0300, Zeeshan Ali (Khattak) wrote:
>> From: "Zeeshan Ali (Khattak)" <zeeshanak gnome org>
>> +osinfo_detect_LDADD = $(GOBJECT_LIBS)             \
>> +                   $(GIO_LIBS)            \
>> +                   $(LIBXML_LIBS)         \
>> +                   -L$(top_srcdir)/osinfo \
>> +                   -losinfo-1.0
>
> I'm not entirely sure if it has any functional difference, but
> I think it is slightly better to remove the -L and -l lines
> and instead reference the .la file directly
>
>    ../osinfo/libosinfo-1.0.la
>
>
> ACK, with that change made before pushing

  Oh, I already made that change after Cosimo pointed out that it
doesn't build for him without it.

-- 
Regards,

Zeeshan Ali (Khattak)
FSF member#5124


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]