[virt-tools-list] [PATCH] virt-manager: fix char device source mode

Cole Robinson crobinso at redhat.com
Thu Sep 1 17:24:16 UTC 2011


On 08/30/2011 03:03 PM, Marc-André Lureau wrote:
> ---
>  src/virtManager/addhardware.py |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/src/virtManager/addhardware.py b/src/virtManager/addhardware.py
> index b32c80d..cc9394b 100644
> --- a/src/virtManager/addhardware.py
> +++ b/src/virtManager/addhardware.py
> @@ -1295,6 +1295,7 @@ class vmmAddHardware(vmmGObjectUI):
>  
>      def validate_page_char(self):
>          chartype = self.get_char_type()
> +        modebox = self.widget("char-mode")
>          devbox = self.widget("char-device-type")
>          devtype = devbox.get_model()[devbox.get_active()][0]
>          conn = self.conn.vmm
> @@ -1302,6 +1303,7 @@ class vmmAddHardware(vmmGObjectUI):
>          devclass = VirtualCharDevice.get_dev_instance(conn, chartype, devtype)
>  
>          source_path = self.widget("char-path").get_text()
> +        source_mode = modebox.get_model()[modebox.get_active()][0]
>          source_host = self.widget("char-host").get_text()
>          bind_host = self.widget("char-bind-host").get_text()
>          source_port = self.widget("char-port").get_adjustment().value
> @@ -1315,6 +1317,7 @@ class vmmAddHardware(vmmGObjectUI):
>  
>          value_mappings = {
>              "source_path" : source_path,
> +            "source_mode" : source_mode,
>              "source_host" : source_host,
>              "source_port" : source_port,
>              "bind_port": bind_port,

Thanks, pushed upstream.

- Cole




More information about the virt-tools-list mailing list