[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [libosinfo 2/2] Add Udev support



On Fri, Sep 02, 2011 at 02:26:51PM +0300, Zeeshan Ali (Khattak) wrote:
> On Thu, Sep 1, 2011 at 1:38 PM, Daniel P. Berrange <berrange redhat com> wrote:
> > On Tue, Aug 30, 2011 at 09:30:16PM +0300, Zeeshan Ali (Khattak) wrote:
> >> From: "Zeeshan Ali (Khattak)" <zeeshanak gnome org>
> >>
> >> +if WITH_UDEV
> >> +udevdir = /lib/udev/rules.d/
> >> +udev_DATA = 95-osinfo.rules
> >> +BUILT_SOURCES = 95-osinfo.rules
> >> +
> >> +95-osinfo.rules: 95-osinfo.rules.in
> >> +     sed 's,\ bindir\@,$(exec_prefix)/bin,' 95-osinfo.rules.in > 95-osinfo.rules
> >> +endif
> >
> > Can be simplified to
> >
> >     sed 's,\ bindir\@,$(exec_prefix)/bin,' $< > $@
> 
>   So with this modification included, do I have an ACK for this patch?

Yes,

Daniel


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]