[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [libosinfo 2/6] Add Resources class



On Wed, Sep 14, 2011 at 04:13:04PM +0300, Zeeshan Ali (Khattak) wrote:
> On Wed, Sep 14, 2011 at 3:52 PM, Daniel P. Berrange <berrange redhat com> wrote:
> > As a general comment, I wonder if we really need this one to
> > derive from OsinfoEntity. The primary purpose of that base
> > class is so we can do filtering on lists of OS, HVs, etc
> > and their attributes.
> >
> > It seems unlikely we need todo filtering based on resources,
> 
>   I don't agree, in fact I am already using filters on it :)
> 
> https://gitorious.org/virt-installer/virt-installer/blobs/master/virt-installer.js#line117

Haha. There's nothing like a bit of code to prove me wrong :-)
So ignore my previous comments on this patch, ACK to your
proposal

> 
> > so could we simplify life and just derive from GObject
> > directly and thus use plain old GObject properties, instead
> > of the OsinfoEntity properties. It might make the bindings
> > a little nicer to use.
> 
>   We can expose these as properties as well.
> 
> > I actually have the same thought about the OsinfoMedia
> > object class too.
> 
>  Don't know of other kinds of filtering but similar to Resources, one
> might need/want to filter medias by architecture as well.
> 


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]