[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [virt-viewer] Document -f=auto-conf in remote-viewer --help



Hey,

On Fri, Aug 10, 2012 at 03:03:05PM +0100, Daniel P. Berrange wrote:
> On Fri, Aug 10, 2012 at 04:00:30PM +0200, Christophe Fergeau wrote:
> > virt-viewer does not support -f=auto-conf so this does not change the
> > option there.
> > Fixes rhbz#718001
> > ---
> > This is an attempt at fixing rhbz#718001 but the message may be
> > too verbose this way, maybe the description would be more appropriate
> > in a man page.
> > 
> >  src/remote-viewer-main.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/src/remote-viewer-main.c b/src/remote-viewer-main.c
> > index a671c18..615e758 100644
> > --- a/src/remote-viewer-main.c
> > +++ b/src/remote-viewer-main.c
> > @@ -216,7 +216,7 @@ main(int argc, char **argv)
> >          { "debug", '\0', 0, G_OPTION_ARG_NONE, &debug,
> >            N_("Display debugging information"), NULL },
> >          { "full-screen", 'f', G_OPTION_FLAG_OPTIONAL_ARG, G_OPTION_ARG_CALLBACK, option_fullscreen,
> > -          N_("Open in full screen mode (=<auto-conf>)"), NULL },
> > +          N_("Open in full screen mode (auto-conf adjusts guest resolution to fit the client's)."), N_("<auto-conf>") },
> >  #if HAVE_SPICE_GTK
> >          { "spice-controller", '\0', 0, G_OPTION_ARG_NONE, &controller,
> >            N_("Open connection using Spice controller communication"), NULL },
> 
> ACK, I think its good enough as it is here

Sorry I'm not sure I understand your answer. Is that an ACK to push this
patch, or an ACK about the concerns about the message verbosity and man
page (ie a 'don't push this patch, let's keep the code as it is
currently')?

Thanks,

Christophe

Attachment: pgpbEfjyO8J8Y.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]