[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH 5/6] Add function to fetch console keyboard layout



On Wed, Jul 25, 2012 at 4:20 PM, Daniel P. Berrange <berrange redhat com> wrote:
> On Tue, Jul 24, 2012 at 10:05:17PM +0200, Fabiano FidĂȘncio wrote:
>> Similar as found on Boxes, this function can be useful for all linuxes,
>> so, is better put it into our API
>
> While I agree its a useful function, I don't think it should go in
> the libosinfo library. I'd like libosinfo to remain as a metadata
> driven database.
>
> This is keymap lookup & translation is something that I think
> would be useful in a "libvirt installer" library, which is
> something we're about to start working on real soon. So I'll
> keep this code in mind for that.

While I agree on what you are saying here, I must point out that
different installer scripts mean different things when they talk of
keyboard layout. Same goes for language selection. Since the whole
point of this API is for apps to not care about OS-specifics, we need
to figure and document what kind of values we expect for these
configuration options.


-- 
Regards,

Zeeshan Ali (Khattak)
FSF member#5124


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]