[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [virt-manager PATCH v2] [RFC] Make deleting storage files default with added prompt



On 12/03/2012 11:12 AM, Martin Kletzander wrote:
> This patch changes the default checkbox-state of "Delete all
> associated storage" to be checked, but adds a prompt with a warning
> for users to be sure they notice this change and they know what they
> are doing (hopefully).
> ---
> I tried playing with this and it works, but unfortunately after the
> configuration gets changed few times.  I haven't tried on a clean
> machine, so it maybe a problem of some old schemas being stuck in
> there.  Feel free to correct my thoughts and patch.
> 
> v2:
>  - there is no configuration for what the default state should be,
>    it's changed to 'checked' by default, but there is a prompt added
> 

Patch is already pushed, but a nice addition would be changing the 'are you
sure' dialog to explicitly list the disk paths that are about to be deleted.
Not a blocker though.

Thanks,
Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]