[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH] [virt-viewer] Make .desktop file comply with spec



On 04.12.2012 23:23, Doug Goldstein wrote:
> The .desktop file did not comply with the Desktop Entry spec as checked
> with desktop-file-validate. Boolean keys are defined as taking only
> 'true' or 'false', the entry Terminal had False. MimeType is a string
> list and therefore must be terminated with a ;
> ---
>  src/remote-viewer.desktop |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/remote-viewer.desktop b/src/remote-viewer.desktop
> index f930592..7de7f6e 100644
> --- a/src/remote-viewer.desktop
> +++ b/src/remote-viewer.desktop
> @@ -2,5 +2,5 @@
>  Name=Remote Viewer
>  Exec=remote-viewer %u
>  Type=Application
> -Terminal=False
> -MimeType=x-scheme-handler/spice
> +Terminal=false
> +MimeType=x-scheme-handler/spice;
> 

ACKed & pushed. I've added you to AUTHORS as well:

diff --git a/AUTHORS b/AUTHORS
index 1b39be9..9f24c26 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -14,6 +14,7 @@ With additional patches from:
     Atsushi SAKAI <sakaia jp fujitsu com>
     Chris Lalancette <clalance redhat com>
     Dave Allan <dallan redhat com>
+    Doug Goldstein <cardoe cardoe com>
     Guannan Ren <gren redhat com>
     Guido G\374nther <agx sigxcpu org>
     Hans de Goede <hdegoede redhat com>

Thanks!

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]