[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [virt-viewer][PATCH 1/2] Sanitize syntax-check



Hi

----- Mensaje original -----
> make syntax-check is producing some errors about empty line at EOF
> and missing #include <config.h> in src/windows-cmdline-wrapper.c
> 

You mean in src/virt-viewer-file.c ?

I would rather add <config.h> there than an exception.

> * cfg.mk: add a syntax-rule exception
> * data/virt-viewer-debug.nsis.in: remove empty line at EOF
> ---
>  cfg.mk                         |    4 ++--
>  data/virt-viewer-debug.nsis.in |    1 -
>  2 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/cfg.mk b/cfg.mk
> index 30392d4..adeda43 100644
> --- a/cfg.mk
> +++ b/cfg.mk
> @@ -128,8 +128,8 @@ sc_check_author_list:
>  
>  exclude_file_name_regexp--sc_preprocessor_indentation = ^*/*.[ch]
>  exclude_file_name_regexp--sc_prohibit_strcmp = ^*/*.[ch]
> -exclude_file_name_regexp--sc_require_config_h =
> ^plugin/|src/gbinding\.c|src/windows-cmdline-wrapper.c
> -exclude_file_name_regexp--sc_require_config_h_first =
> ^plugin/|src/gbinding\.c|src/windows-cmdline-wrapper.c
> +exclude_file_name_regexp--sc_require_config_h =
> ^plugin/|src/gbinding\.c|src/windows-cmdline-wrapper\.c|src/virt-viewer-file\.c
> +exclude_file_name_regexp--sc_require_config_h_first =
> ^plugin/|src/gbinding\.c|src/windows-cmdline-wrapper.c|src/virt-viewer-file\.c
>  
>  exclude_file_name_regexp--sc_prohibit_empty_lines_at_EOF = ^icons/
>  exclude_file_name_regexp--sc_trailing_blank = ^icons/
> diff --git a/data/virt-viewer-debug.nsis.in
> b/data/virt-viewer-debug.nsis.in
> index 8d8d499..103b080 100644
> --- a/data/virt-viewer-debug.nsis.in
> +++ b/data/virt-viewer-debug.nsis.in
> @@ -47,4 +47,3 @@ SectionEnd
>  Section -post
>    WriteUninstaller "$INSTDIR\Uninstall-debug.exe"
>  SectionEnd
> -
> --
> 1.7.8.6
> 
> _______________________________________________
> virt-tools-list mailing list
> virt-tools-list redhat com
> https://www.redhat.com/mailman/listinfo/virt-tools-list
> 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]