[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [libosinfo 1/5] syms: Remove duplicated symbol



On Fri, Dec 07, 2012 at 12:31:36PM +0100, Michal Privoznik wrote:
> On 07.12.2012 09:46, Christophe Fergeau wrote:
> > libosinfo.syms contains the osinfo_install_config_param_new symbol
> > twice. Reorder the LIBOSINFO_0.2.0 section to make this obvious,
> > and remove the duplicated symbol.
> > ---
> >  osinfo/libosinfo.syms | 5 ++---
> >  1 file changed, 2 insertions(+), 3 deletions(-)
> > 
> > diff --git a/osinfo/libosinfo.syms b/osinfo/libosinfo.syms
> > index fe1ac16..3821416 100644
> > --- a/osinfo/libosinfo.syms
> > +++ b/osinfo/libosinfo.syms
> > @@ -267,6 +267,8 @@ LIBOSINFO_0.2.0 {
> >  	osinfo_install_config_set_hostname;
> >  	osinfo_install_config_param_get_type;
> >  	osinfo_install_config_param_new;
> > +	osinfo_install_config_param_get_name;
> > +	osinfo_install_config_param_get_policy;
> >  	osinfo_install_script_set_output_prefix;
> >  	osinfo_install_script_get_type;
> >  	osinfo_install_script_new;
> > @@ -290,9 +292,6 @@ LIBOSINFO_0.2.0 {
> >  	osinfo_install_scriptlist_new_intersection;
> >  	osinfo_install_scriptlist_new_copy;
> >  	osinfo_install_scriptlist_get_type;
> > -	osinfo_install_config_param_new;
> > -	osinfo_install_config_param_get_name;
> > -	osinfo_install_config_param_get_policy;
> >  	osinfo_db_get_install_script;
> >  	osinfo_db_add_install_script;
> >  	osinfo_db_get_install_script_list;
> > 
> 
> While we should never change set of exported symbols esp. for previous
> releases, this one make perfect sense. ACK

Thanks, series pushed.

Christophe

Attachment: pgpN8ao6361ks.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]