[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [libosinfo 2/2] loader: Fix one newly introduced leak



On Fri, Dec 07, 2012 at 12:10:04PM +0100, Michal Privoznik wrote:
> On 07.12.2012 09:30, Christophe Fergeau wrote:
> > This is a follow-up to my previous series fixing leaks as a similar
> > one was just introduced.
> > ---
> >  osinfo/osinfo_loader.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/osinfo/osinfo_loader.c b/osinfo/osinfo_loader.c
> > index 62b92f9..e630793 100644
> > --- a/osinfo/osinfo_loader.c
> > +++ b/osinfo/osinfo_loader.c
> > @@ -961,8 +961,10 @@ static OsinfoDeviceDriver *osinfo_loader_driver(OsinfoLoader *loader,
> >      }
> >  
> >      gint nnodes = osinfo_loader_nodeset("./*", ctxt, &nodes, err);
> > -    if (error_is_set(err))
> > +    if (error_is_set(err)) {
> > +        g_object_unref(G_OBJECT(driver));
> >          return NULL;
> > +    }
> >  
> >      for (i = 0 ; i < nnodes ; i++) {
> >          if (nodes[i]->children &&
> > 
> 
> Fortunately, both these patches looks sane. ACK.

Thanks, I've pushed the 2nd patch as the first one was already in.

Christophe

Attachment: pgp3u6HGuoI1V.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]