[virt-tools-list] [libosinfo 2/2] fedora, installer: Set keyboard config for >= F18

[Zeeshan Ali (Khattak)]

On Fri, Dec 7, 2012 at 10:06 AM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> On Fri, Dec 07, 2012 at 03:43:37AM +0200, Zeeshan Ali (Khattak) wrote:
>> On Thu, Dec 6, 2012 at 4:06 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
>> > On Thu, Dec 06, 2012 at 03:12:36PM +0200, Zeeshan Ali (Khattak) wrote:
>> >> On Wed, Dec 5, 2012 at 6:08 PM, Zeeshan Ali (Khattak)
>> >> <zeeshanak at gnome.org> wrote:
>> >> > On Wed, Dec 5, 2012 at 5:56 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
>> >> >> Hey
>> >> >
>> >> > Hi,
>> >> >
>> >> >> I don't think it's good to duplicate the mapping twice, and that's a good
>> >> >> candidate for these datamaps.
>> >> >
>> >> > I agree but for now we can do it this way. Once we have the datamaps
>> >> > in place, we can make use of them here.
>> >>
>> >> So whats the verdict on this?
>> >
>> > "I don't think it's good to duplicate the mapping twice".
>>
>> I understood this very simple sentence the first time too. :) I also
>> said that I agree with it. I only wanted to know if its OK like that
>> for now to improve later. I guess the answer is 'no' then.
>
> It depends, you did not explain at all why you'd prefer to keep things this
> way for now. If it would take significant time to remove the duplication,
> then I could get convinced, but without explanations/arguments it's hard to
> make a decision.
>
>>
>> > And adding
>> > datamaps don't seem that hard, looking into it at the moment...
>>
>> Hopefully you are correct, we'll see once you are done. In the
>> meantime, the keyboard setting API remains broken.
>
> As long as we are not about to make a new libosinfo release, this can wait
> a few more days, right?

I really don't see the point of waiting. When something is broken, the
priority should be fixing the issue as soon as possible, even if the
only solution available is ugly as long as you ensure you don't forget
to clean it soon afterwards.

-- 
Regards,

Zeeshan Ali (Khattak)
FSF member#5124