[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [libosinfo 2/2] fedora, installer: Set keyboard config for >= F18



On Fri, Dec 7, 2012 at 3:55 PM, Zeeshan Ali (Khattak)
<zeeshanak gnome org> wrote:
> On Fri, Dec 7, 2012 at 3:41 PM, Christophe Fergeau <cfergeau redhat com> wrote:
>> On Fri, Dec 07, 2012 at 02:52:24PM +0200, Zeeshan Ali (Khattak) wrote:
>>> On Fri, Dec 7, 2012 at 10:06 AM, Christophe Fergeau <cfergeau redhat com> wrote:
>>> > It depends, you did not explain at all why you'd prefer to keep things this
>>> > way for now. If it would take significant time to remove the duplication,
>>> > then I could get convinced, but without explanations/arguments it's hard to
>>> > make a decision.
>>> >
>>
>>> >
>>> > As long as we are not about to make a new libosinfo release, this can wait
>>> > a few more days, right?
>>>
>>> I really don't see the point of waiting.
>>
>> For now, things are waiting on you addressing my review comments from this
>> email.
>
> I really don't see any way to remove the duplication other than either
> using datamaps or removing the fix for one of the profiles.

Does that address your review comment or is this still waiting on me?

-- 
Regards,

Zeeshan Ali (Khattak)
FSF member#5124


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]