[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [libosinfo 6/8] Deprecate osinfo_db_guess_os_from_media



On Wed, Dec 05, 2012 at 06:46:06PM +0200, Zeeshan Ali (Khattak) wrote:
> On Mon, Dec 3, 2012 at 1:23 PM, Christophe Fergeau <cfergeau redhat com> wrote:
> > ---
> >  osinfo/osinfo_db.c | 38 +++++++++++++++++++++++---------------
> >  osinfo/osinfo_db.h |  1 +
> >  2 files changed, 24 insertions(+), 15 deletions(-)
> >
> > diff --git a/osinfo/osinfo_db.c b/osinfo/osinfo_db.c
> > index 1e8a93c..46101d6 100644
> > --- a/osinfo/osinfo_db.c
> > +++ b/osinfo/osinfo_db.c
> > @@ -391,20 +391,10 @@ static gint media_volume_compare (gconstpointer a, gconstpointer b)
> >          return 1;
> >  }
> >
> > -/**
> > - * osinfo_db_guess_os_from_media:
> > - * @db: the database
> > - * @media: the installation media
> > - * @matched_media: (out) (transfer none) (allow-none): the matched operating
> > - * system media
> > - *
> > - * Guess operating system given a #OsinfoMedia object.
> > - *
> > - * Returns: (transfer none): the operating system, or NULL if guessing failed
> > - */
> > -OsinfoOs *osinfo_db_guess_os_from_media(OsinfoDb *db,
> > -                                        OsinfoMedia *media,
> > -                                        OsinfoMedia **matched_media)
> > +static OsinfoOs *
> > +osinfo_db_guess_os_from_media_internal(OsinfoDb *db,
> > +                                       OsinfoMedia *media,
> > +                                       OsinfoMedia **matched_media)
> >  {
> >      OsinfoOs *ret = NULL;
> >      GList *oss = NULL;
> > @@ -460,6 +450,23 @@ OsinfoOs *osinfo_db_guess_os_from_media(OsinfoDb *db,
> >
> >      return ret;
> >  }
> > +/**
> > + * osinfo_db_guess_os_from_media:
> > + * @db: the database
> > + * @media: the installation media
> > + * @matched_media: (out) (transfer none) (allow-none): the matched operating
> > + * system media
> > + *
> > + * Guess operating system given a #OsinfoMedia object.
> > + *
> > + * Returns: (transfer none): the operating system, or NULL if guessing failed
> > + */
> 
> Don't we need some deprecation note in the doc?

Yes, added now.

Christophe

Attachment: pgpetmFdwtS8G.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]