[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [libosinfo PATCHv3 10/12] Add osinfo_install_config_new_for_script



On Wed, Dec 12, 2012 at 5:18 PM, Christophe Fergeau <cfergeau redhat com> wrote:
> In order to be able to automatically transform configuration parameters set
> on OsinfoInstallConfig instances (ie translate from generic value to
> OS-specific value),

Hmm.. this seemingly small change is rather a big change in terms of
API design as so far we have kept install config separate from install
script. They only meet each other when generating scripts from
template.

Since the OS-specific values are actually needed when transforming the
template to script (i-e in osinfo_install_script_generate_config_xml),
 I wonder if there is another less intrusive (in terms of API) way to
achieve the goal. One idea that comes to mind is to create a
OS-specific temporary config (internally) based on the pass (to
_install_script_generate*) config and script.

Also how would the app know which _new() to use? If we accept this
change, I reluctantly suggest we deprecate the other _new().

-- 
Regards,

Zeeshan Ali (Khattak)
FSF member#5124


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]