[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [libosinfo v2 1/3] Add missing documentation



On Mon, Dec 17, 2012 at 08:30:35AM -0200, Fabiano Fidêncio wrote:
> On Mon, Dec 17, 2012 at 8:26 AM, Christophe Fergeau <cfergeau redhat com> wrote:
> > On Mon, Dec 17, 2012 at 08:10:16AM -0200, Fabiano Fidêncio wrote:
> >> On Mon, Dec 17, 2012 at 7:47 AM, Christophe Fergeau <cfergeau redhat com> wrote:
> >> > On Mon, Dec 17, 2012 at 07:24:34AM -0200, Fabiano Fidêncio wrote:
> >> >> Annotations for:
> >> >> - osinfo_install_script_generate_finish()
> >> >> - osinfo_install_script_generate_output_finish()
> >> >
> >> > and osinfo_media_get_os and osinfo_media_set_languages (thanks for adding
> >> > these, I had totally overlooked that). Did you get warnings about the
> >> > missing _set_languages annotation? the symbol is not exported.
> >>
> >> Yes, I did.
> >> I'm passing --warn-all to g-ir-scanner.I'm also getting these 2
> >> warnings that I have no clue how to fix: http://pastebin.com/KPVBCzCe
> >
> > I think these are just small typos:
> 
> And this is the proof I need to sleep :)
> Please, commit your patch (it's trivial) and thank you :)

Yeah I nearly pushed it as trivial, but I've posted it as you have a way to
test it ;)

Christophe

Attachment: pgp5GNQri0rHD.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]