[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH v2 1/2] spec: Add pod2man to build requisites



On Mon, Dec 17, 2012 at 1:22 PM, Martin Kletzander <mkletzan redhat com> wrote:
> On 12/14/2012 05:03 PM, Fabiano Fidêncio wrote:
>> On Fri, Dec 14, 2012 at 1:57 PM, Martin Kletzander <mkletzan redhat com> wrote:
>>> As commit 06838b31 made manpages created in build phase, pod2man needs
>>> to be added as a BuildRequires into the specfile.
>>> ---
>>>  python-virtinst.spec.in | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/python-virtinst.spec.in b/python-virtinst.spec.in
>>> index 27136c2..352a8b9 100644
>>> --- a/python-virtinst.spec.in
>>> +++ b/python-virtinst.spec.in
>>> @@ -50,6 +50,7 @@ Requires: libselinux-python
>>>  %endif
>>>  BuildRequires: gettext
>>>  BuildRequires: python
>>> +BuildRequires: /usr/bin/pod2man
>>
>> Would be better if could use a not hardcoded path, no?
>>
>
> From what I know, the BuildRequires knows only about path (starting with
> '/') or package.  I thought adding pod2man is better than adding perl,
> but, frankly, I don't know about any other implementation of pod2man, so
> I'm ok with changing it to perl.

Nevermind, you were right with your first approach!
Christophe Fergeau had clarified my mind about your patch but looks
like we forgot to reply saying that :)

>
> Martin


Best Regards and sorry about confusion,
--
Fabiano Fidêncio


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]