[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [virt-install PATCH] Add pre-generated virt-install.pod to fix freshly-cloned repos

On 12/19/2012 09:36 AM, Martin Kletzander wrote:
> Feeling really dull, I'm adding the 'man/en/virt-install.pod'
> (generated on current HEAD), because I wrongly assumed that it is
> being kept in the repo when redesigning the build with its
> dependencies, but I missed that it was listed in '.gitignore'.
> The file should be kept in the repository in order for the build to be
> working in a freshly cloned repo.  The file then gets updated whenever
> 'python setup.py sdist' is ran, hence it is kept up-to date with
> releases.
> ---
>  .gitignore              |    1 -
>  man/en/virt-install.pod | 1432 +++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 1432 insertions(+), 1 deletion(-)
>  create mode 100644 man/en/virt-install.pod

hmm, this patch is mildly problematic though, in that it becomes unclear what
a user should edit to make man page changes. They can edit virt-install.pod,
commit it, but at next sdist those changes will be overwritten.

In practice it's not that big of a deal since I'm generally the only one who
touches the man pages anyways.

I've applied this now. Once we switch to lisosinfo, we can drop the OS list
from the man page and just point to 'osinfo-query os', and the build can be


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]