[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [osinfo PATCH] Rework udev rule some more



On Fri, Jan 27, 2012 at 7:04 PM, Christophe Fergeau <cfergeau redhat com> wrote:
> Now that the rules to remove device properties when the CD is ejected
> have been fixed, another bug in these rules shows up: there are 2 rules
> very similar to the rules for disk insertion. One of them matches
> ID_FS_TYPE != "iso9660" and the other matches ID_FS_TYPE != "udf" which
> means that at least one of them will trigger and will remove the
> OSINFO_* properties that have been just set by the insertion rules.

Good catch!

> While attempting to fix them, I've noticed that these properties go
> away anyway when the disk is removed (??),

I don't quite remember why I decided to have those clean-up rules but
IIRC it was that if you re-insert the disk the old properties were
re-used. Anyway if you could test what happens when you remove these
rules and re-insert media?

> so we can get rid of them.
> While at it, I've added a test to check that the 'change' events correspond
> to a media change.

Oh, didn't know there was a variable/prop for that. Nice!

-- 
Regards,

Zeeshan Ali (Khattak)
FSF member#5124


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]