[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH 03/12] Use graphical URI for connection



On Tue, Dec 13, 2011 at 08:35:01PM +0100, Marc-André Lureau wrote:
> If specified, use URI for connection details
> ---
>  src/virt-viewer-app.c |   37 ++++++++++++++++++++++++++++++++++---
>  src/virt-viewer-app.h |    3 ++-
>  src/virt-viewer.c     |    2 +-
>  3 files changed, 37 insertions(+), 5 deletions(-)
> 
> diff --git a/src/virt-viewer-app.c b/src/virt-viewer-app.c
> index 3d02a0a..a7867ba 100644
> --- a/src/virt-viewer-app.c
> +++ b/src/virt-viewer-app.c
> @@ -114,6 +114,7 @@ struct _VirtViewerAppPrivate {
>  	gboolean connected;
>  	guint reconnect_poll; /* source id */
>  	char *unixsock;
> +	char *guri; /* prefered over ghost:gport */
>  	char *ghost;
>  	char *gport;
>  	char *host; /* ssh */

As with the previous patch, I'm not really liking this
way of dealing with URIs. I think we should just parse
the URI and put the pieces into the fields we already
have


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]