[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH 04/12] Add remote-viewer program



On Tue, Dec 13, 2011 at 08:35:02PM +0100, Marc-André Lureau wrote:
> This program is meant for direct URI connections.
> ex: remote-viewer vnc://uri
> ---
>  .gitignore               |    3 +
>  po/POTFILES.in           |    2 +
>  src/Makefile.am          |  108 ++++++++++++++++++++-------------
>  src/remote-viewer-main.c |  148 ++++++++++++++++++++++++++++++++++++++++++++++
>  src/remote-viewer.c      |  141 +++++++++++++++++++++++++++++++++++++++++++
>  src/remote-viewer.h      |   56 +++++++++++++++++


Need to also change virt-viewer.spec.in & mingw32-virt-viewer.spec.in
to include the new binary

> diff --git a/src/Makefile.am b/src/Makefile.am
> index 4643de9..e1e0ee9 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -1,57 +1,79 @@
> +NULL =
> +# we are forced to use a shared library,
> +# because libtool reordred .a after .la libs, and it fails to link
> +lib_LTLIBRARIES = libvirt-viewer.la

The codebase is small enough that you could just list the sources
against both binaries. It'll compile them twice, but that's not
all that bad really, compared to having to install a shared lib

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]