[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH virt-viewer 04/17] Add remote-viewer program




----- Mensaje original -----
> On Fri, Jan 27, 2012 at 02:51:23PM +0100, Marc-André Lureau wrote:
> > From: Marc-André Lureau <marcandre lureau redhat com>
> > 
> > This program is meant for direct URI connections.
> > ex: remote-viewer vnc://uri
> > ---
> >  .gitignore                  |    3 +
> >  mingw32-virt-viewer.spec.in |    1 +
> >  po/POTFILES.in              |    2 +
> >  src/Makefile.am             |  108
> >  +++++++++++++++++++-------------
> >  src/remote-viewer-main.c    |  148
> >  +++++++++++++++++++++++++++++++++++++++++++
> >  src/remote-viewer.c         |  141
> >  +++++++++++++++++++++++++++++++++++++++++
> >  src/remote-viewer.h         |   56 ++++++++++++++++
> >  virt-viewer.spec.in         |    1 +
> >  8 files changed, 417 insertions(+), 43 deletions(-)
> >  create mode 100644 src/remote-viewer-main.c
> >  create mode 100644 src/remote-viewer.c
> >  create mode 100644 src/remote-viewer.h
> 
> After this change is applied, all the signal handling in virt-viewer
> is broken, so I had to stop testing at this point (aside from a
> couple
> of later patches I could cherry-pick without merge conflicts)
> 
> $ ./src/virt-viewer vm-spice
> 
> (virt-viewer:28827): Gtk-WARNING **: Could not find signal handler
> 'virt_viewer_window_delete'
> 
> (virt-viewer:28827): Gtk-WARNING **: Could not find signal handler
> 'virt_viewer_window_menu_help_about'
> 
> (virt-viewer:28827): Gtk-WARNING **: Could not find signal handler
> 'virt_viewer_window_menu_send'
> 
> ....many many more...

Hans reported the problem today, remote-viewer is missing GMODULE2 flags. I probably dropped it inadvertently after a rebase..


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]