[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH 10/10] Add desktop profile for Windows



On Wed, Jun 13, 2012 at 4:47 PM, Zeeshan Ali (Khattak)
<zeeshanak gnome org> wrote:
> On Wed, Jun 13, 2012 at 6:49 PM, Daniel P. Berrange <berrange redhat com> wrote:
>> On Wed, Jun 13, 2012 at 06:44:29PM +0300, Zeeshan Ali (Khattak) wrote:
>>>
>>> >  <install-script id='http://microsoft.com/windows/sif'>
>>> >    <profile>desktop</profile>
>>> >
>>> >    <assets>
>>> >       <disk media='floppy'/>
>>> ..
>>> >  <install-script id='http://fedoraproject.org/kickstart'>
>>> >    <profile>desktop</profile>
>>> >
>>> >    <assets>
>>> >       <disk media='harddisk'/>
>>>
>>> How do we make sure that we assume the correct device name/number/path
>>> in the scripts? Why not have these as configuration parameters as well
>>> so that app tells us where to find these? Some parameters could be
>>> mandatory: app gets error if it doesn't set these params.
>>
>> I'd say the rule is that the disk external "data" disk should be the
>> first available unit number, after the primary VM disks. As written
>> the install scripts assume only a single primary VM disk is used.
>> If we wanted to allow more, we'd have to add a new parameter to the
>> install script API to allow the app to specify how many disks it is
>> attaching.
>
> How does libosinfo knows what is the primary disk? Let me explain by
> example: For fedora (or linux in general) the path to primary target
> disk could be either /dev/vda or /dev/sda, depending on whether virtio
> is being used or not. This will also impact the name/path of the
> unattended disk: /dev/sda or /dev/sdb depending on whether /dev/sda is
> being used for primary disk or not.

To be honest, it doesn't matter.
IIUC, Boxes will support only "newer" distros (Fedora 15+, for example).
And these distros, always, have support to virtio. So, we don't need
to worry about it.
Our first disk will always be /dev/vda and the disk with the image
will always be /dev/sda.

Daniel, Zeeshan, it makes sense for you?

>
> --
> Regards,
>
> Zeeshan Ali (Khattak)
> FSF member#5124



-- 
Fabiano Fidêncio


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]