[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH virt-viewer 03/19] spice: disconnect signal handlers when either object is destroyed



On Tue, Jul 17, 2012 at 12:50:36PM +0200, Marc-André Lureau wrote:
> On Tue, Jul 17, 2012 at 10:37 AM, Christophe Fergeau
> <cfergeau redhat com> wrote:
> > Why do you need to do this? Are you seeing concrete issues? Or will it be
> > needed by subsequent changes?
> 
> "This function
> will take care of removing signal handler if any of emitter or
> attached object are destroyed."

Yes, I understand what it does, I asked you _why_ it's needed.

> 
> The following patches will have this condition met, since there is no
> longer 1-1 relation between channel and display. The channels can
> continue to be around when some of the display are removed.

add this explanation to the commit log then ;)

Christophe

Attachment: pgpAxnMGPcc38.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]