[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH 2/6] Don't return a gboolean when a gchar * is expected



On Tue, Jul 24, 2012 at 10:05:14PM +0200, Fabiano Fidêncio wrote:
> ---
>  osinfo/osinfo_install_script.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/osinfo/osinfo_install_script.c b/osinfo/osinfo_install_script.c
> index 7bf1e2e..1f437a1 100644
> --- a/osinfo/osinfo_install_script.c
> +++ b/osinfo/osinfo_install_script.c
> @@ -627,10 +627,10 @@ gchar *osinfo_install_script_generate_finish(OsinfoInstallScript *script,
>  {
>      GSimpleAsyncResult *simple = G_SIMPLE_ASYNC_RESULT(res);
>  
> -    g_return_val_if_fail(error == NULL || *error == NULL, FALSE);
> +    g_return_val_if_fail(error == NULL || *error == NULL, NULL);
>  
>      if (g_simple_async_result_propagate_error(simple, error))
> -        return FALSE;
> +        return NULL;
>  
>      return g_simple_async_result_get_op_res_gpointer(simple);
>  }

ACK


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]