[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH] build: allow building with newer glibc-headers and -O0



On 06/08/2012 09:38 AM, Christophe Fergeau wrote:
> From: Eric Blake <eblake redhat com>

It's weird seeing my name as author.  Perhaps you ought to claim
authorship, and just credit me in the commit message without giving me
authorship, since porting my libvirt patch to libosinfo was all your effort.

> 
> glibc 2.15 (on Fedora 17) coupled with explicit disabling of
> optimization during development dies a painful death:

> +++ b/m4/libosinfo-compile-warnings.m4
> @@ -86,8 +86,13 @@ AC_DEFUN([LIBOSINFO_COMPILE_WARNINGS],[
>      gl_WARN_ADD([-Wframe-larger-than=4096])
>  
>      # Use improved glibc headers
> -    AC_DEFINE([_FORTIFY_SOURCE], [2],
> -      [enable compile-time and run-time bounds-checking, and some warnings])
> +    AH_VERBATIM([FORTIFY_SOURCE],
> +    [/* Enable compile-time and run-time bounds-checking, and some warnings,
> +        without upsetting newer glibc. */
> +     #if defined __OPTIMIZE__ && __OPTIMIZE__

Not to mention that you actually squashed two libvirt patches into a
single libosinfo patch (although I agree with what you've done).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]