[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH 10/10] Add desktop profile for Windows



On Wed, Jun 13, 2012 at 06:44:29PM +0300, Zeeshan Ali (Khattak) wrote:
> On Wed, Jun 13, 2012 at 1:25 PM, Daniel P. Berrange <berrange redhat com> wrote:
> > Considering all of this data, what if we were to change the <install-script>
> > XML syntax to allow multiple output files, and also provide metadata about
> > the external disk that needs to be provided, and the images (or other files)
> > within it.
> >
> > eg something like:
> 
> Yeah, sounds good. An alternative could be that we also provide the
> API to create the disk images for apps. On the plus side, that'll make
> app developers' lives much much easier but on the negative side I
> think we might be going way too far by depending on external apps like
> dosutils in libosinfo.

Yes, that's a job for our separate (yet to be written API) "libvirt-ginstall"

> 
> >  <install-script id='http://microsoft.com/windows/sif'>
> >    <profile>desktop</profile>
> >
> >    <assets>
> >       <disk media='floppy'/>
> ..
> >  <install-script id='http://fedoraproject.org/kickstart'>
> >    <profile>desktop</profile>
> >
> >    <assets>
> >       <disk media='harddisk'/>
> 
> How do we make sure that we assume the correct device name/number/path
> in the scripts? Why not have these as configuration parameters as well
> so that app tells us where to find these? Some parameters could be
> mandatory: app gets error if it doesn't set these params.

I'd say the rule is that the disk external "data" disk should be the
first available unit number, after the primary VM disks. As written
the install scripts assume only a single primary VM disk is used.
If we wanted to allow more, we'd have to add a new parameter to the
install script API to allow the app to specify how many disks it is
attaching.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]