[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH 09/11] virt_viewer_app_quit: Cleanly close the connection before quiting



Hi,

Thanks for the reviews!!

On 03/04/2012 10:02 PM, Marc-André Lureau wrote:
On Sun, Mar 4, 2012 at 8:06 PM, Hans de Goede<hdegoede redhat com>  wrote:
+    if (priv->quiting)
+        gtk_main_quit();
+

That looks like it will break "virt-viewer --reconnect", if a
disconnection happens, it will try to reconnect on machine re-start. I
haven't checked though, I will if you don't beat me to it.

The quiting flag only gets set from virtviewer_app_quit, which before
this patch itself would unconditionally call gtk_main_quit, iow
when a code path calls virtviewer_app_quit it really wants to quit,
and since quiting only get sets from there I don't see how this can
break reconnecting.

Regards,

Hans


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]