[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH 1/4] virt-viewer-window: Remove useless tests for priv->window != NULL



Hi,

On 03/05/2012 06:30 PM, Marc-André Lureau wrote:
On Mon, Mar 5, 2012 at 4:22 PM, Hans de Goede<hdegoede redhat com>  wrote:
priv->window gets set on init and never unset, so there is no need to check
for it.

It's remaining code from the browser plugin support, which has been
broken for a long time.. if you continue in this direction, you'll
probably end up removing all related code.. instead, I think we should
try to keep in mind that a window may not always be available etc.. At
least, that's what we tried to do I think..

Ah I didn't know that, but given that there are already a gazillion code
paths which assume that priv->window is always there, I don't think this
patch makes things worse, on the contrary it at least makes it clear that
there is no support at all atm for not having priv->window so that if someone
ever tries to resurrect the browser plugin he will know where he stands.

So I personally vote to rip out the last checks, and then re-visit (and
possibly re-think) this if / when we look at doing a browser plugin again.

Regards,

Hans


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]