[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH 3/4] virt-viewer-window: Add show / hide utility functions



Hi,

On 03/05/2012 06:34 PM, Marc-André Lureau wrote:
Sounds reasonable

On Mon, Mar 5, 2012 at 4:22 PM, Hans de Goede<hdegoede redhat com>  wrote:
-    win = virt_viewer_window_get_window(priv->main_window);
-    if (win)
-        gtk_widget_show(GTK_WIDGET(win));
-    else {
-        gtk_box_pack_end(GTK_BOX(priv->container), priv->main_notebook, TRUE, TRUE, 0);
-        gtk_widget_show(GTK_WIDGET(priv->main_notebook));
-    }

Although this will also remove some plugin support code.

Like the previous patch it seems that we assume we always have a main_window in
various places, and even if we did not, the plugin support this removes seems
something to me which should be abstracted away inside the window object ...

Anyways if you want me to somehow re-spin this patch to be more kind to the
plugin support leftovers let me know.

Regards,

Hans


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]