[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH libosinfo 1/2] Move database files into $datadir/db instead of $datadir/data



On Tue, Mar 13, 2012 at 6:32 PM, Daniel P. Berrange <berrange redhat com> wrote:
> From: "Daniel P. Berrange" <berrange redhat com>

ACK to both patches otherwise, one comment only to this one:

> index 337f737..b009323 100644
> --- a/osinfo/osinfo_loader.c
> +++ b/osinfo/osinfo_loader.c
> @@ -1271,11 +1271,14 @@ void osinfo_loader_process_default_path(OsinfoLoader *loader,
>                                         GError **err)
>  {
>     GFile *file;
> +    gchar *dbdir;
>     const gchar *path = getenv("OSINFO_DATA_DIR");
>     if (!path)
> -        path = DATA_DIR;
> +        path = PKG_DATA_DIR;
>
> -    file = g_file_new_for_path(path);
> +    dbdir = g_strdup_printf("%s/db", path);

Why not just pass the whole path from CFLAGS just like DATA_DIR?

-- 
Regards,

Zeeshan Ali (Khattak)
FSF member#5124


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]