[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH virt-viewer 1/4] Fix indentation



Ack series.

One remark about 2/4:
"spice: implement --fullscreen=auto-conf"
which is probably best fixed in a follow up patch.
Now that we have --fullscreen=auto-conf, we can
also implement the display-flags controller
CONTROLLER_AUTO_DISPLAY_RES flag properly, as
that is equivalent to --fullscreen=auto-conf,
so we should modify remote-viewer.c:
spice_ctrl_notified() to handle this and set
the "fullscreen-auto-conf" property on self
to the value of the CONTROLLER_AUTO_DISPLAY_RES.

Regards,

Hans




On 03/18/2012 07:59 PM, Marc-André Lureau wrote:
---
  src/virt-viewer-app.c |   26 +++++++++++++-------------
  1 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/src/virt-viewer-app.c b/src/virt-viewer-app.c
index 789cb88..e30df85 100644
--- a/src/virt-viewer-app.c
+++ b/src/virt-viewer-app.c
@@ -680,20 +680,20 @@ virt_viewer_app_create_session(VirtViewerApp *self, const gchar *type)
      } else
  #endif
  #ifdef HAVE_SPICE_GTK
-        if (g_ascii_strcasecmp(type, "spice") == 0) {
-            GtkWindow *window = virt_viewer_window_get_window(priv->main_window);
-            virt_viewer_app_trace(self, "Guest %s has a %s display\n",
-                                  priv->guest_name, type);
-            priv->session = virt_viewer_session_spice_new(window);
-        } else
+    if (g_ascii_strcasecmp(type, "spice") == 0) {
+        GtkWindow *window = virt_viewer_window_get_window(priv->main_window);
+        virt_viewer_app_trace(self, "Guest %s has a %s display\n",
+                              priv->guest_name, type);
+        priv->session = virt_viewer_session_spice_new(window);
+    } else
  #endif
-            {
-                virt_viewer_app_trace(self, "Guest %s has unsupported %s display type\n",
-                                      priv->guest_name, type);
-                virt_viewer_app_simple_message_dialog(self, _("Unknown graphic type for the guest %s"),
-                                                      priv->guest_name);
-                return -1;
-            }
+    {
+        virt_viewer_app_trace(self, "Guest %s has unsupported %s display type\n",
+                              priv->guest_name, type);
+        virt_viewer_app_simple_message_dialog(self, _("Unknown graphic type for the guest %s"),
+                                              priv->guest_name);
+        return -1;
+    }

      g_signal_connect(priv->session, "session-initialized",
                       G_CALLBACK(virt_viewer_app_initialized), self);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]