[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH virt-viewer 4/5] build-sys: simplify autogen.sh



>> -set -e
>> +set -ex
>
> This should be dropped

It needs to exit in case of error. It's better if it's verbose in this
case (autogen.sh/configure is pretty verbose anyway)
> Should we keep this logging?
>

Since we error out with the failing command above, I don't think it's
necessary. And I expect autoreconf to do some meaningful checks too.

> -v doesn't seem to be very helpful here

No, it's just useful to know what autoreconf is doing, but we can drop it.

I like silent build of source code, because it helps to spot code
errors. In case of  the build system itself, I don't mind if it is
verbose when it needs to be setup. Ie, a verbose step that should spot
all potential build issues before get you to a silent state, where you
want only what concerns the code.

> Does ${1+"$@"} bring much over "$@"? Isn't it a bashism? The shebang is
> still #!/bin/sh

No, dropped.

-- 
Marc-André Lureau


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]