[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH] virtinst:change default disk bus type into scsi on pseries machine



Hi Cole:
Cole ,would you please help to review this patch,this patch change default disk bus type from ide to scsi on pseries machine (pseries doesn't support ide bus type).When use virt-manager to install os form cdrom,the cdrom config page in details page is not generated yet,so there is no user interface to change that during this process.

On 05/24/2012 04:44 PM, Qing Lin wrote:
When install OS from cdrom ,the default cdrom disk bus type is "ide",
which is not supported on pseries machine.But there is no interface to
change it through the whole install process.So we should set "scsi"
(pseries machine support) as default disk type on pseries machine.

Signed-off-by: Qing Lin<qinglbj linux vnet ibm com>
Signed-off-by: Li Zhang<zhlcindy linux vnet ibm com>
---
  virtinst/Guest.py |    6 +++++-
  1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/virtinst/Guest.py b/virtinst/Guest.py
index 93e407f..23b4946 100644
--- a/virtinst/Guest.py
+++ b/virtinst/Guest.py
@@ -1503,7 +1503,11 @@ class Guest(XMLBuilderDomain.XMLBuilderDomain):
                      disk.bus = "fdc"
                  else:
                      if self.installer.is_hvm():
-                        disk.bus = "ide"
+                        if (self.installer.type == "kvm" and
+                            self.installer.machine == "pseries"):
+                            disk.bus = "scsi"
+                        else:
+                            disk.bus = "ide"
                      elif self.installer.is_xenpv():
                          disk.bus = "xen"
              used_targets.append(disk.generate_target(used_targets))


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]