[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [libosinfo 4/5] InstallConfigParam props should map to entity params

On Fri, Nov 9, 2012 at 3:41 PM, Michal Privoznik <mprivozn redhat com> wrote:
> On 08.11.2012 18:24, Zeeshan Ali (Khattak) wrote:
>> From: "Zeeshan Ali (Khattak)" <zeeshanak gnome org>
>> Without entity params usage, there is no real benefit of deriving from
>> Entity class so this was very much intended from start.
>> This change also corrects the gobject property for 'policy':
>> 1. to be of its enum type. Although this means ABI "breakage", we must keep in
>>    mind:
>>   a. The property getter (the API used by apps) was treating the string
>>      value as enum, i-e it was broken for apps so if any app is using this
>>      API, they were totally screwed anyways.
>>   b. Its doubtful that this new API is used by any application out there.
>> 2. not be writable. This actually not only breaks ABI but also the API:
>> we remove one argument of _new() function. As said above, the prop
>> getter is the main part of this API that an app will be using if its
>> using this API at all so I think its worth it to correct this while are
>> are causing other breakage.
>> ---
>>  osinfo/osinfo_install_config_param.c | 80 ++++++++++++++++--------------------
>>  osinfo/osinfo_install_config_param.h |  5 ++-
>>  osinfo/osinfo_loader.c               | 30 +++++++-------
>>  3 files changed, 56 insertions(+), 59 deletions(-)
> While I am usually not real friend of API/ABI breakage, I think this
> cannot achieved by any other means.

FWIW, I feel the same way. :)

> ACK if nobody objects.

Thanks. Christophe recommended I divide this patch further so I
divided it into 4 patches now. I'll resend them so I'll have to bother
you to re-ACK them.


Zeeshan Ali (Khattak)
FSF member#5124

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]