[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH virt-viewer 0/7] RFC: read session parameters from file


Set looks good to me overall. Only thing I'm wondering is why have
VirtViewerFile in virt-viewer and not make it a SpiceFile and put it
in spice-client-glib ?

The main advantage I can think of for having it in virt-viewer
would be making vnc connections in a similar way, but you don't
add that in the current patch set, do you plan to add this later?



On 11/23/2012 01:41 PM, Marc-André Lureau wrote:

RHEVM portal sets up remote-viewer using the Spice Controller [1] (a
browser applet will spawn the client, and connect to it to communicate
connection details and other messages)

In order to avoid the need for an extra communication channels and
browser applets, we could use a simple text file containing all the
necessary informations, allowing easier portability and testing.

This file is not specific to Spice. It could be used as well to start
VNC connections, and configure the client.

We keep the RHEVM/Spice format for description of hotkeys, to avoid
breaking exisiting configuration. Eventually, new fields could be
added later with Gtk accel format instead.

[1] http://spice-space.org/page/Whiteboard/ControllerProtocol

Marc-André Lureau (7):
   session: add virt_viewer_session_mime_type()
   recent: get mime type from session
   Move spice_hotkey_to_gtk_accelerator() to util
   Add VirtViewerFile
   Add VirtViewerSession:file property
   spice: learn to connect from file
   remote-viewer: learn to connect from file

  src/Makefile.am                 |   1 +
  src/remote-viewer-main.c        |  10 +-
  src/remote-viewer.c             | 140 ++------
  src/virt-viewer-file.c          | 775 ++++++++++++++++++++++++++++++++++++++++
  src/virt-viewer-file.h          | 102 ++++++
  src/virt-viewer-session-spice.c |  95 ++++-
  src/virt-viewer-session-vnc.c   |   6 +
  src/virt-viewer-session.c       |  51 +++
  src/virt-viewer-session.h       |   5 +
  src/virt-viewer-util.c          | 113 ++++++
  src/virt-viewer-util.h          |   2 +
  11 files changed, 1178 insertions(+), 122 deletions(-)
  create mode 100644 src/virt-viewer-file.c
  create mode 100644 src/virt-viewer-file.h

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]