[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [libosinfo v4] API to query required user avatar format



On Fri, Nov 23, 2012 at 9:59 AM, Christophe Fergeau <cfergeau redhat com> wrote:
> On Fri, Nov 23, 2012 at 05:26:19AM +0200, Zeeshan Ali (Khattak) wrote:
>> @@ -157,6 +165,8 @@ osinfo_install_script_finalize (GObject *object)
>>      g_free(script->priv->output_prefix);
>>      g_free(script->priv->output_filename);
>>      g_list_free_full(script->priv->config_param_list, g_object_unref);
>> +    if (script->priv->avatar != NULL)
>> +        g_object_unref(script->priv->avatar);
>
>
> I've heard a few times that g_*_free should be done in _finalize while
> g_object_unref should be called from _dispose. I don't know how important
> this is (ie we can probably live with this _unref in _finalize).

Moreover this pattern is all over in libosinfo so I always think maybe
its better to be consistent about this. If it turns out to be an
issue, we can move all these unrefs into _dispose at the same time.

-- 
Regards,

Zeeshan Ali (Khattak)
FSF member#5124


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]