[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH virt-viewer 5/7] Add VirtViewerSession:file property



On Fri, Nov 23, 2012 at 01:41:10PM +0100, Marc-André Lureau wrote:
> If VirtViewerSession:file is set, it should be used to define the
> connection parameters. Also correct the mime type used in this case.

A bit confused by the commit log, use of the file to define the connection
parameters is done in the next commit. The 'Also' is a clear hint that this
commit should be split, and it would have been nice to explain why this
mime type is needed in the log.

Looks good otherwise, ACK.

Christophe

Attachment: pgpgKp1Yw6xjS.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]