[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH virt-viewer 6/7] spice: learn to connect from file



On Fri, Nov 23, 2012 at 01:41:11PM +0100, Marc-André Lureau wrote:
> ---
>  src/virt-viewer-session-spice.c | 88 ++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 87 insertions(+), 1 deletion(-)
> 
> diff --git a/src/virt-viewer-session-spice.c b/src/virt-viewer-session-spice.c
> index 3d48ba3..ae68ec2 100644
> --- a/src/virt-viewer-session-spice.c
> +++ b/src/virt-viewer-session-spice.c
> @@ -29,6 +29,7 @@
>  
>  #include <spice-option.h>
>  #include <usb-device-widget.h>
> +#include "virt-viewer-file.h"
>  #include "virt-viewer-util.h"
>  #include "virt-viewer-session-spice.h"
>  #include "virt-viewer-display-spice.h"
> @@ -252,16 +253,101 @@ virt_viewer_session_spice_open_host(VirtViewerSession *session,
>      return spice_session_connect(self->priv->session);
>  }
>  
>  static gboolean
>  virt_viewer_session_spice_open_uri(VirtViewerSession *session,
>                                     const gchar *uri)
>  {
>      VirtViewerSessionSpice *self = VIRT_VIEWER_SESSION_SPICE(session);
> +    VirtViewerFile *file = virt_viewer_session_get_file(session);
> +    VirtViewerApp *app = virt_viewer_session_get_app(session);

Nit: this 'app' variable could go in the if (file){} block

looks good otherwise, ACK.

Christophe

Attachment: pgp7f9vd1Zqrn.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]