[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH virt-viewer 6/7] spice: learn to connect from file



On Tue, Nov 27, 2012 at 01:59:14PM +0100, Marc-André Lureau wrote:
> Hi
> 
> On Tue, Nov 27, 2012 at 10:49 AM, Christophe Fergeau <cfergeau redhat com>wrote:
> 
> > Nit: this 'app' variable could go in the if (file){} block
> 
> 
> I am not convinced that change is really worth it here, I'll keep it that
> way if you don't mind.

I don't mind at all. I tend to keep local variables in the smallest block
possible as this makes it much easier to know when it's relevant and when
it's not relevant.

Christophe

Attachment: pgpQIngWK4yXI.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]