[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [libosinfo 3/5] Fix OsinfoMedia::installer-reboots default value



On Wed, Nov 28, 2012 at 10:58 AM, Christophe Fergeau
<cfergeau redhat com> wrote:
> On Wed, Nov 28, 2012 at 01:29:54AM +0200, Zeeshan Ali (Khattak) wrote:
>> On Wed, Nov 28, 2012 at 12:39 AM, Christophe Fergeau
>> <cfergeau redhat com> wrote:
>> > In other words,
>> > am I introducing a regression,
>>
>> Well its not really causing a regression but its not fixing anything either.
>
> Definitely not, it just makes the code more consistent (same value for the
> gobject default property value and in the
> osinfo_entity_get_value_with_default).

Not sure how can still state this as a fact while I already told you
how its not.

> Do you want me to change something
> in this patch or drop it?

As I said, this change is not needed so the latter.

-- 
Regards,

Zeeshan Ali (Khattak)
FSF member#5124


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]