[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [libosinfo] fedora, installer: Fix against Fedora 18



On Thu, Nov 29, 2012 at 12:22 AM, Zeeshan Ali (Khattak)
<zeeshanak gnome org> wrote:
> On Thu, Nov 29, 2012 at 3:54 AM, Fabiano Fidêncio <fabiano fidencio org> wrote:
>> On Wed, Nov 28, 2012 at 1:47 PM, Fabiano Fidêncio <fabiano fidencio org> wrote:
>>> On Wed, Nov 28, 2012 at 1:44 PM, Zeeshan Ali (Khattak)
>>> <zeeshanak gnome org> wrote:
>>>> From: "Zeeshan Ali (Khattak)" <zeeshanak gnome org>
>>>>
>>>> 'base' package group has been replaced by 'standard'. For jeos profile,
>>>> we now use the right name of the group depending on the OS version. For
>>>> desktop profile, we can simply drop this group from the list as its
>>>> pulled-in by other groups anyways.
>>>> ---
>>>>  data/install-scripts/fedora.xml | 8 +++++++-
>>>>  1 file changed, 7 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/data/install-scripts/fedora.xml b/data/install-scripts/fedora.xml
>>>> index fcb1143..e76f5dd 100644
>>>> --- a/data/install-scripts/fedora.xml
>>>> +++ b/data/install-scripts/fedora.xml
>>>> @@ -94,7 +94,14 @@ logvol / --fstype <xsl:call-template name="rootfs"/> --name=LogVol00 --vgname=Vo
>>>>  reboot
>>>>
>>>>  %packages
>>>> +<xsl:choose>
>>>> +  <xsl:when test="os/version &lt; 18">
>>>>  @base
>>>> +  </xsl:when>
>>>> +  <xsl:otherwise>
>>>> + standard
>>>> +  </xsl:otherwise>
>>>> +</xsl:choose>
>>>>  @core
>>>>  <xsl:if test="os/version &gt; 6">
>>>>  @hardware-support
>>>> @@ -200,7 +207,6 @@ logvol / --fstype <xsl:call-template name="rootfs"/> --name=LogVol00 --vgname=Vo
>>>>  reboot
>>>>
>>>>  %packages
>>>> - base
>>>>  @core
>>>>  @hardware-support
>>>>  @base-x
>>>> --
>>>> 1.8.0
>>>>
>>>> _______________________________________________
>>>> virt-tools-list mailing list
>>>> virt-tools-list redhat com
>>>> https://www.redhat.com/mailman/listinfo/virt-tools-list
>>>
>>> ACK
>>
>> Since I ACK'ed it is my fault.
>> Zeeshan, your modification only affects jeos profiles. Could you c&p
>> the code also for desktop profiles?
>
> Its also covered. Read the commit log and don't miss this change :)

The moment you realize it's time to sleep! :)

>
>>>>  %packages
>>>> - base
>>>>  @core
>>>>  @hardware-support
>>>>  @base-x
>
> --
> Regards,
>
> Zeeshan Ali (Khattak)
> FSF member#5124


Best Regards,
--
Fabiano Fidêncio


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]